test: replaced common.fixturesDir usage with common.fixtures module#15947
Closed
andyband7 wants to merge 2 commits intonodejs:masterfrom
Closed
test: replaced common.fixturesDir usage with common.fixtures module#15947andyband7 wants to merge 2 commits intonodejs:masterfrom
andyband7 wants to merge 2 commits intonodejs:masterfrom
Conversation
Trott
added
the
code-and-learn
BridgeAR
reviewed
Oct 7, 2017
| let err; | ||
| const badSyntaxPath = | ||
| path.join(common.fixturesDir, 'syntax', 'bad_syntax') | ||
| path.join(fixtures.fixturesDir, 'syntax', 'bad_syntax') |
Member
There was a problem hiding this comment.
I think this should actually use the fixtures.path function.
Member
There was a problem hiding this comment.
For instance,
const badSyntaxPath = fixtures.path('syntax', 'bad_syntax');
Member
|
Ping @andyband7 |
Contributor
Author
|
Thanks for the reminder @BridgeAR . Ive committed an updated test, is this how you meant it? |
gireeshpunathil
approved these changes
Oct 19, 2017
Member
Member
|
AIX issue was not related to this PR. |
Member
|
Windows failures was a not related to this PR. CI run looks good. |
Member
|
@BridgeAR if the change matches what you had in mind I think this is ready to land. |
BridgeAR
approved these changes
Oct 19, 2017
joyeecheung
approved these changes
Oct 19, 2017
| let err; | ||
| const badSyntaxPath = | ||
| path.join(common.fixturesDir, 'syntax', 'bad_syntax') | ||
| fixtures.path('syntax', 'bad_syntax') |
Member
There was a problem hiding this comment.
nit: this line can be merged with the line above now. This can be handled during landing
Member
|
Landed in 76abf0f, thanks! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 19, 2017
PR-URL: #15947 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
PR-URL: #15947 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#15947 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15947 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15947 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15947 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#15947 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the usage of common.fixturesDir and replaces with common.fixtures module
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test